Re: [Xen-devel] [PATCH v2 for 4.5] ioreq-server: handle the lack of a default emulator properly

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxx [mailto:xen-devel-
> bounces@xxxxxxxxxxxxx] On Behalf Of Jan Beulich
> Sent: 30 September 2014 10:04
> To: Paul Durrant
> Cc: Keir (Xen.org); xen-devel@xxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH v2 for 4.5] ioreq-server: handle the lack of a
> default emulator properly
> 
> >>> On 29.09.14 at 12:21, <paul.durrant@xxxxxxxxxx> wrote:
> > +static bool_t hvm_complete_assist_req(ioreq_t *p)
> > +{
> > +    switch (p->type)
> > +    {
> > +    case IOREQ_TYPE_COPY:
> > +    case IOREQ_TYPE_PIO:
> > +        if ( p->dir == IOREQ_READ )
> > +        {
> > +            if ( !p->data_is_ptr )
> > +                p->data = ~0ul;
> > +            else
> > +            {
> > +                int i, sign = p->df ? -1 : 1;
> > +                uint32_t data = ~0;
> > +
> > +                for ( i = 0; i < p->count; i++ )
> > +                    hvm_copy_to_guest_phys(p->data + sign * i * p->size, 
> > &data,
> > +                                           p->size);
> 
> It's not clear which code you cloned this from - these constructs did
> all get replaced by commit f21399e148 ("x86/HVM: properly handle
> backward string instruction emulation "), and hence this new addition
> has to follow suit.
> 

Ok. It was some old code I had lying around. I'll have a look at that commit.

  Paul

> Jan
> 
> > +            }
> > +        }
> > +        /* FALLTHRU */
> > +    default:
> > +        p->state = STATE_IORESP_READY;
> > +        hvm_io_assist(p);
> > +        break;
> > +    }
> > +
> > +    return 1;
> > +}
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel