Re: [Xen-devel] [PATCH for-4.5] libxl: don't use a qemu-ifup script on FreeBSD

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

El 29/09/14 a les 15.35, Ian Campbell ha escrit:
> On Fri, 2014-09-26 at 14:07 -0400, Konrad Rzeszutek Wilk wrote:
>> On Fri, Sep 26, 2014 at 06:14:12PM +0200, Roger Pau Monne wrote:
>>> FreeBSD doesn't use any qemu-ifup script in order to setup the network, it
>>> is all done on the hotplug script like Linux.
>>>
>>> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
>>> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
>>> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>>> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
>>> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
>>> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
>>> ---
>>> I request a code freeze exception on the basis that this is a bugfix and it
>>> doesn't change the behaviour on platforms different than FreeBSD.
>>
>> <nods>
>>
>> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
> Applied.
> 
> I'm wondering if anyone should be using qemu-ifup these days?

AFAIR, NetBSD uses it for qemu-trad at least. I was tempted to invert
the ifdef and do something like:

#ifdef __NetBSD__
        ... use qemu-ifup
#else
        ... no ifup script
#endif

But I have no idea what Solaris does, or if we still try to support it.

Anyway, thanks for applying this.

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel