Re: [Xen-devel] [PATCH 01/28] Neutralize make uninstall

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-09-25 at 17:19 +0200, Olaf Hering wrote:
> The uninstall target does not know about the paths it removes because
> the toplevel Makefile does not include the required files.
> 
> Remove all dangerous commands.

Of these only "rm -f $(D)$(XEN_RUN_DIR)*" seems especially dangerous. 

The rest will remove things like /*.conf and /xendomains which is
bad/wrong but not usually catastrophic 

>  There is no replacement.

Yet? Will this be replaced by additions to the appropriate submake files
in the course of this series?
 
> The proper fix is to remove the files and directories in the Makefiles
> which install them.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> Cc: Keir Fraser <keir@xxxxxxx>
> Cc: Tim Deegan <tim@xxxxxxx>
> ---
>  Makefile | 15 +--------------
>  1 file changed, 1 insertion(+), 14 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 3b9bf7a..abef019 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -232,21 +232,8 @@ help:
>  .PHONY: uninstall
>  uninstall: D=$(DESTDIR)
>  uninstall:
> -     [ -d $(D)$(XEN_CONFIG_DIR) ] && mv -f $(D)$(XEN_CONFIG_DIR) 
> $(D)$(XEN_CONFIG_DIR).old-`date +%s` || true
>       $(MAKE) -C xen uninstall
> -     rm -rf $(D)$(CONFIG_DIR)/init.d/xendomains $(D)$(CONFIG_DIR)/init.d/xend
> -     rm -rf $(D)$(CONFIG_DIR)/init.d/xencommons 
> $(D)$(CONFIG_DIR)/init.d/xen-watchdog
> -     rm -f  $(D)$(CONFIG_DIR)/udev/rules.d/xen-backend.rules
> -     rm -f  $(D)$(CONFIG_DIR)/udev/rules.d/xend.rules
> -     rm -f  $(D)$(SYSCONFIG_DIR)/xendomains
> -     rm -f  $(D)$(SBINDIR)/xendomains
> -     rm -f  $(D)$(SYSCONFIG_DIR)/xencommons
> -     rm -f  $(D)$(XEN_SYSTEMD_DIR)/*.service
> -     rm -f  $(D)$(XEN_SYSTEMD_DIR)/*.mount
> -     rm -f  $(D)$(XEN_SYSTEMD_MODULES_LOAD)/*.conf
> -     rm -rf  $(D)$(XEN_RUN_DIR)* $(D)/var/lib/xen*
> -     make -C tools uninstall
> -     rm -rf $(D)/boot/tboot*
> +     $(MAKE) -C tools uninstall
>  
>  .PHONY: xenversion
>  xenversion:
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel