Re: [Xen-devel] [PATCH for 4.5 v2 2/2] x86/hvm: Improve "Emulation failed @" error messages

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.09.14 at 18:24, <andrew.cooper3@xxxxxxxxxx> wrote:
> @@ -1449,6 +1441,30 @@ struct segment_register *hvmemul_get_seg_reg(
>      return &hvmemul_ctxt->seg_reg[seg];
>  }
>  
> +static const char *guest_x86_mode_to_str(int mode)
> +{
> +    switch ( mode )
> +    {
> +    case 0 ... 2: return "16bit";

I don't really follow why you dropped the real and vm86 mode
special casing here (nor do I think ???_guest_x86_mode() is
producing insufficient detail for the purposes here or elsewhere).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel