Re: [Xen-devel] [PATCH v2 00/22] Use MSI chip framework to configure MSI/MSI-X in all platforms

[Yijing Wang <wangyijing@xxxxxxxxxx>]

>>>> What I would like to see is a way of creating the pci_host_bridge 
>>>> structure outside
>>>> the pci_create_root_bus(). That would then allow us to pass this sort of 
>>>> platform
>>>> details like associated msi_chip into the host bridge and the child busses 
>>>> will
>>>> have an easy way of finding the information needed by finding the root bus 
>>>> and then
>>>> the host bridge structure. Then the generic pci_scan_root_bus() can be 
>>>> used by (mostly)
>>>> everyone and the drivers can remove their kludges that try to work around 
>>>> the
>>>> current limitations.
>>
>> So I think maybe save msi chip in PCI arch sysdata is a good candidate.
> 
> Except that arch sysdata at the moment is an opaque pointer. I am all in 
> favour in
> changing the type of sysdata from void* into pci_host_bridge* and arches can 
> wrap their old
> sysdata around the pci_host_bridge*.

I inspected every arch and found there are almost no common stuff, and generic 
data struct should
be created in generic PCI code. Another, I don't like associate msi chip and 
every PCI device, further more,
almost all platforms except arm have only one MSI controller, and currently, 
PCI enumerating code doesn't need
to know the MSI chip details, like for legacy IRQ, PCI device doesn't need to 
know which IRQ controller they
should deliver IRQ to. I would think more about it, and hope other PCI guys can 
give some comments, especially from Bjorn.

Thanks!
Yijing.

> 
> Best regards,
> Liviu
> 
>>
>>>
>>> I think both issues are orthogonal. Last time I checked a lot of work
>>> was still necessary to unify host bridges enough so that it could be
>>> shared across architectures. But perhaps some of that work has
>>> happened in the meantime.
>>>
>>> But like I said, when you create the root bus, you can easily attach the
>>> MSI chip to it.
>>>
>>> Thierry
>>>
>>
>>
>> -- 
>> Thanks!
>> Yijing
>>
>>
> 


-- 
Thanks!
Yijing


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel