Re: [Xen-devel] [PATCH for-4.5] pygrub: fix read sizes on FreeBSD

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH for-4.5] pygrub: fix read sizes on FreeBSD"):
> FreeBSD only allows reading multiples of sector size from raw disk devices
> (character devices). This fix should only alter the behaviour of pygrub on
> FreeBSD, the other supported OSes will continue using the same size.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

> I request a code freeze exception on the basis that this is a bugfix and it
> doesn't change the behaviour on platforms different than FreeBSD.

This sounds reasonable to me (but of course the decision is Konrad's).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel