Re: [Xen-devel] [PATCH v6 for-4.5 4/5] xl: add 'trim' and 'split_string_into_pair' functions

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("Re: [PATCH v6 for-4.5 4/5] xl: add 'trim' and 
'split_string_into_pair' functions"):
> On Fri, Sep 26, 2014 at 04:45:30PM +0100, Ian Jackson wrote:
> > I disagree.  I think in general a function that takes any kind of
> > pointer should be assumed to require a non-NULL pointer.  It should
> > not carry out any kind of nullness check; it should just dereference
> > the pointer (and consequently crash if it is NULL).
...
> Fair enough. I don't really have strong preference on this kind of
> issue. We just need to have an agreement on which route we take. 

Right.  The rest of libxl follows the convention I describe above.  So
I think this aspect of Dave's patch is fine.

Iabn.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel