Re: [Xen-devel] [PATCH v3 9/9] oxenstored: reduce syslog call overhead (fix typo)

[Zheng Li <dev@xxxxxxxx>]

Hi Ian,

On 26/09/2014 16:16, Ian Jackson wrote:
> Zheng Li writes ("Re: [PATCH v3 9/9] oxenstored: reduce syslog call overhead (fix 
> typo)"):
> > Setting up the TZ environment varialbe to avoid stat calls.
> ...
> > +               if not tz_is_set then Unix.putenv "TZ" ":/etc/localtime" in
> I wasn't aware of this syntax.  Can you point me to its specification ?
Please see the 3rd format (:characters format) in the linked document below

http://www.gnu.org/software/libc/manual/html_node/TZ-Variable.html

Also a similar issue reported on stackoverflow and discussion

http://stackoverflow.com/questions/4554271/how-to-avoid-excessive-stat-etc-localtime-calls-in-strftime-on-linux

I've manually tested the change. With TZ set, strace no longer shows the 
intensive stat calls, and the timestamps seem to be correct wrt the local time 
setting.

Cheers,
Zheng


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel