Re: [Xen-devel] [PATCH v2 2/5] xenfb: Activate mouse event handler

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 17 Sep 2014, Owen smith wrote:
> Without activating the mouse event handler, mouse events are not
> delivered to the new handler. Input events are only delivered to
> the first matching handler in the input chain. Activating a handler
> moves the handler to the start of the chain.
> 
> Note: qemu_add_kbd_event_handler adds and activates the keyboard
> handler, where qemu_add_mouse_event_handler does not activate the
> mouse handler.

how strange


> Signed-off-by: Owen smith <owen.smith@xxxxxxxxxx>

Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>


> ---
>  hw/display/xenfb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
> index 9dcf9b6..69471e9 100644
> --- a/hw/display/xenfb.c
> +++ b/hw/display/xenfb.c
> @@ -383,6 +383,7 @@ static void input_connected(struct XenDevice *xendev)
>      in->qmouse = qemu_add_mouse_event_handler(xenfb_mouse_event, in,
>                                             in->abs_pointer_wanted,
>                                             "Xen PVFB Mouse");
> +    qemu_activate_mouse_event_handler(in->qmouse);
>  
>      if (in->qkbd) {
>          qemu_remove_kbd_event_handler(in->qkbd);
> -- 
> 2.1.0
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel