Re: [Xen-devel] [PATCH for-4.5 v20 07/12] xl/remus: change bool to defbool

[Shriram Rajagopalan <rshriram@xxxxxxxxx>]

On Sep 25, 2014 3:21 PM, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx> wrote:
>
> On Thu, Sep 25, 2014 at 02:16:19PM +0800, Yang Hongyang wrote:
> > Use defbool instead of bool for boolean flags in remus_info struct.
>
> While that change by itself looks OK, the change in 'libxl_types.idl'
> break the ABI.
>
> Could you say a bit of why that is OK? As in, would there had
> been in the past any users of this ABI that now would have issues with this?
>

There were no users of the libxl Remus api in the past. Certainly not an API level user like libvirt.

> Also, how important is this patch? Does it have to go in or
> can it be dropped from the patchset?
>

Well, this defbool thing came up as part of the feedback. Dropping this may be of little consequence but there are new additions to the libxl Remus struct (enable or disable net/disk buffer), that will break compatibility. But we can't drop these patches.

> >

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel