Re: [Xen-devel] [PATCH] libxl: Fix build dependency for libxl.h.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-09-24 at 16:30 +0100, Anthony PERARD wrote:
> libxl.h includes _libxl_list.h, but the Makefile does not reflect this
> dependency. This can lead to build error due to a missing _libxl_list.h
> file.

libxl_qmp.c includes this too, is that a problem?

It's probably unnecessary since it includes libxl.h too. So maybe the
fix is to drop the #include?

> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Acked + applied.

> ---
>  tools/libxl/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
> index 9d67d0b..496a269 100644
> --- a/tools/libxl/Makefile
> +++ b/tools/libxl/Makefile
> @@ -173,7 +173,7 @@ _libxl_save_msgs_helper.h _libxl_save_msgs_callout.h: \
>       $(PERL) -w $< $@ >$@.new
>       $(call move-if-changed,$@.new,$@)
>  
> -libxl.h: _libxl_types.h
> +libxl.h: _libxl_types.h _libxl_list.h
>  libxl_json.h: _libxl_types_json.h
>  libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h 
> _libxl_types_internal_private.h _paths.h
>  libxl_internal_json.h: _libxl_types_internal_json.h




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel