[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2 01/22] PCI/MSI: Clean up struct msi_chip argument
- To: Yijing Wang <wangyijing@xxxxxxxxxx>
- From: Thierry Reding <thierry.reding@xxxxxxxxx>
- Date: Thu, 25 Sep 2014 09:15:38 +0200
- Cc: linux-mips@xxxxxxxxxxxxxx, linux-ia64@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, Bharat.Bhushan@xxxxxxxxxxxxx, sparclinux@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, Russell King <linux@xxxxxxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Joerg Roedel <joro@xxxxxxxxxx>, x86@xxxxxxxxxx, Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx>, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, arnab.basu@xxxxxxxxxxxxx, Arnd Bergmann <arnd@xxxxxxxx>, Chris Metcalf <cmetcalf@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>, Xinwei Hu <huxinwei@xxxxxxxxxx>, Tony Luck <tony.luck@xxxxxxxxx>, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Ralf Baechle <ralf@xxxxxxxxxxxxxx>, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, David Vrabel <david.vrabel@xxxxxxxxxx>, Wuyun <wuyun.wu@xxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Lucas Stach <l.stach@xxxxxxxxxxxxxx>
- Delivery-date: Thu, 25 Sep 2014 08:07:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On Thu, Sep 25, 2014 at 11:14:11AM +0800, Yijing Wang wrote:
> Msi_chip functions setup_irq/teardown_irq rarely use msi_chip
> argument.
That's not true. Out of the four drivers that you modify two use the
parameter. And the two that don't probably should be using it too.
50% is not "rarely". =)
> We can look up msi_chip pointer by the device pointer
> or irq number, so clean up msi_chip argument.
I don't like this particular change. The idea was to keep the API object
oriented so that drivers wouldn't have to know where to get the MSI chip
from. It also makes it more resilient against code reorganizations since
the core code is the only place that needs to know where to get the chip
from.
Thierry
Attachment:
pgp4BV2OSeWD7.pgp
Description: PGP signature
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
