Re: [Xen-devel] Introduce rtds real-time scheduler for Xen

[Meng Xu <xumengpanda@xxxxxxxxx>]

2014-09-23 9:50 GMT-04:00 Ian Campbell <Ian.Campbell@xxxxxxxxxx>:
> On Sun, 2014-09-14 at 17:37 -0400, Meng Xu wrote:
>> This serie of patches adds rtds real-time scheduler to Xen.
>
> I've applied v4 of this series, which was apparently unthreaded and had
> no introductory email (hence replying to what I think is v3's intro).
>
> For the avoidance of doubt I've applied the patches with these
> message-ids in this order:
>
> <1411251228-2093-1-git-send-email-mengxu@xxxxxxxxxxxxx>
> <1411251258-2131-1-git-send-email-mengxu@xxxxxxxxxxxxx>
> <1411251283-2169-1-git-send-email-mengxu@xxxxxxxxxxxxx>
> <1411251302-2207-1-git-send-email-mengxu@xxxxxxxxxxxxx>
>
> I think that's right but I suggest you check that the end result in the
> staging branch corresponds with what you thought you were sending.

Yes, all of these are correct. I double-checked that and run them.

>
> Note that tools/libxc/xenctrl.h moved to tools/libxc/include/xenctrl.h
> since your patch was posted and I fixed that up as I went. Also, it
> didn't build for arm32 due to:
>
>         sched_rt.c: In function âburn_budgetâ:
>         sched_rt.c:630:17: error: format â%ldâ expects argument of type âlong 
> intâ, but argument 3 has type âs_time_tâ [-Werror=format]
>
> I therefore folded this into the first patch:
>
> diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c
> index 4c522bb..6c8faeb 100644
> --- a/xen/common/sched_rt.c
> +++ b/xen/common/sched_rt.c
> @@ -626,7 +626,7 @@ burn_budget(const struct scheduler *ops, struct rt_vcpu 
> *svc, s_time_t now)
>       */
>      if ( delta < 0 )
>      {
> -        printk("%s, ATTENTION: now is behind last_start! delta = %ld\n",
> +        printk("%s, ATTENTION: now is behind last_start! 
> delta=%"PRI_stime"\n",
>                  __func__, delta);
>          svc->last_start = now;
>          return;
>
> (this seemed easier than another round trip, I hope it is ok)

It's right! Thank you so much!

>
> Apart from trying not to  forget the introductory mail and threading in
> the future, please use the same $subject prefix on the introductory mail
> as the rest of the series (e.g. '[PATCH for 4.5 v4 0/4]: Introduce rtds
> real-time scheduler for Xen'), so I can figure out what goes with what.

I will remember that and avoid this. I used my gmail to send the
introductory email and used my school's email to send the patches,
that could be the reason why it's hard to find the introductory mail.
Anyway, I will avoid this and add the introductory mail as 0/4 as you
said.

Thank you very much!

Best,

Meng

>
> Ian.
>



-- 


-----------
Meng Xu
PhD Student in Computer and Information Science
University of Pennsylvania

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel