Re: [Xen-devel] [PATCH for-4.5 v8 16/19] xen/arm: Instruction prefetch abort (X) mem_event handling

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Wed, Sep 24, 2014 at 5:41 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

Hello Tamas,

On 09/23/2014 02:14 PM, Tamas K Lengyel wrote:
> +        unsigned long s1ptw:1; /* Fault during a stage 1 translation table walk */

[..]

> +        unsigned long s1ptw:1; /* Fault during a stage 1 translation table walk */

The description is confusing, it gives the impression that this bit is
used to know if the fault has occurred a stage 1 translation table walk
or not. I would say: "Stage 2 fault during a stage 1 translation table
walk".

Regards,

--
Julien Grall

That's a bit too long to fit into 80 chars in that line and I don't want to line-break for the comment (looks ugly). Maybe shorten it to "Stage 2 fault during stage 1 translation"?

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel