Re: [Xen-devel] [PATCH v19 07/12] xl/remus: change bool to defbool

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Yang Hongyang writes ("[Xen-devel] [PATCH v19 07/12] xl/remus: change bool to 
defbool"):
> Use defbool instead of bool for boolean flags in remus_info struct.

(For reasons I don't understand, I didn't find a copy of this one
patch in my mailbox.  I fished it out of the list.  Probably this is
Citrix's mail system being broken :-/.)

> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index a9f59db..f3274d3 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -593,8 +593,8 @@ libxl_sched_credit_params = Struct("sched_credit_params", 
> [
>  
>  libxl_domain_remus_info = Struct("domain_remus_info",[
>      ("interval",     integer),
> -    ("blackhole",    bool),
> -    ("compression",  bool),
> +    ("blackhole",    libxl_defbool),
> +    ("compression",  libxl_defbool),

This is an incompatible API change.  We have, in general, promised not
to do that.  But AFAICT there is no working remus in 4.4.  So I think
this is OK.

Can I have a confirmation from someone else that I'm right ?  I can't
seem to find any discussion of this in the most recent posting, and
this instance (v19) of this patch hasn't got an ack or review or
comment along these lines from anyone else.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel