Re: [Xen-devel] [PATCH v5 for-4.5 1/2] libxl: add support for 'channels'

[Dave Scott <Dave.Scott@xxxxxxxxxx>]

On 22 Sep 2014, at 17:17, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:

> David Scott writes ("[PATCH v5 for-4.5 1/2] libxl: add support for 
> 'channels'"):
>> A 'channel':
>>  - is a low-bandwidth private communication channel that resembles
>>    a physical serial port.
>>  - is implemented as a PV console with a well-known string name
>>    which is used to hook the channel to the appropriate software
>>    in the guest (i.e. some kind of guest agent).
>>  - has a backend 'connection' which describes what should happen
>>    to the data.
> 
> This looks good in principle.
> 
> I have a couple of easy quibbles:
> 
> You have forgotten to document that you transport the channel name in
> xenstore in the subkey `name'.  This should be in your `console.txt'
> patch I think, given that xenstore-paths.markdown refers to that for
> all the nodes in .../console.

Good spot. I think I’m blind to some of these documentation problems.

> And the interaction between consoles in the console part of the domain
> configuration and the channels listed in the channels part, should be
> documented.  (Even if it's just that consoles always have no name and
> channels always have one.)

I’ve added some comments to the domain configuration definition in the
IDL and to libxl.h. Interestingly the console device is still an
internal type in libxl_types_internal.idl and not user-configurable via
the libxl_domain_config, so that removes one source of confusion (hopefully)

Cheers,
Dave
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel