Re: [Xen-devel] [PATCH V5 10/15] Add arch specific module handling to read_file()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.09.14 at 03:23, <roy.franz@xxxxxxxxxx> wrote:
> On Mon, Sep 22, 2014 at 6:57 PM, Roy Franz <roy.franz@xxxxxxxxxx> wrote:
>> On Mon, Sep 22, 2014 at 5:44 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>>> On 19.09.14 at 00:50, <roy.franz@xxxxxxxxxx> wrote:
>>>> @@ -274,8 +275,8 @@ static void __init 
>>>> efi_arch_cfg_file_late(EFI_FILE_HANDLE dir_handle, char *sect
>>>>      if ( name.s )
>>>>      {
>>>>          microcode_set_module(mbi.mods_count);
>>>> -        split_value(name.s);
>>>> -        read_file(dir_handle, s2w(&name), &ucode);
>>>> +        options = split_string(name.s);
>>>> +        read_file(dir_handle, &ucode, s2w(&name), options);
>>>
>>> Perhaps rather NULL instead of options?
>>
>> Yup.
>>
> OK, I looked at this a little more, and the original code would take
> anything after the ucode filename
> and put it into the mbi.string field for the ucode module.  All the
> modules where treated the same in this
> regard - they could all have options.
> 
> If ucode never has options, I can remove this, but this would be a
> change in behavior.

This was done that way just to avoid extra conditionals. The resulting
mbi.string doesn't get consumed anywhere (just like for initrd and
xsm, albeit in the latter case one could at least envision a potential
future use).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel