Re: [Xen-devel] [PATCH V5 10/15] Add arch specific module handling to read_file()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 23.09.14 at 03:57, <roy.franz@xxxxxxxxxx> wrote:
> On Mon, Sep 22, 2014 at 5:44 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 19.09.14 at 00:50, <roy.franz@xxxxxxxxxx> wrote:
>>> @@ -115,6 +116,15 @@ static void __init DisplayUint(UINT64 Val, INTN Width)
>>>      PrintStr(PrintString);
>>>  }
>>>
>>> +static size_t __init wstrlen(const CHAR16 * s)
>>> +{
>>> +     const CHAR16 *sc;
>>> +
>>> +     for (sc = s; *sc != L'\0'; ++sc)
>>> +             /* nothing */;
>>> +     return sc - s;
>>> +}
>>
>> Coding style (many issues).
> 
> static size_t __init wstrlen(const CHAR16 *s)
> {
>      const CHAR16 *sc;
> 
>      for ( sc = s; *sc != L'\0'; ++sc )
>             ;
>      return sc - s;
> }
> 
> Is the above OK?  Not sure what else to change here...

Almost - the lone ; is still indented one level (4 spaces) too deep.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel