Re: [Xen-devel] [PATCH v3 1/4] xen: add real time scheduler rtds

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Sat, Sep 20, 2014 at 10:10 PM, Meng Xu <xumengpanda@xxxxxxxxx> wrote:
>>
>> These svc structures are allocated dynamically and may disappear at any
>> time... I think you need the lock to cover this as well.
>>
>> And since this is called both externally (via ops->dump_cpu_state) and
>> internally (below), you probably need a locking version and a non-locking
>> version (normally you'd make rt_dump_pcpu() a locking "wrapper" around
>> __rt_dump_pcpu()).
>
>
> I tried to add the schedule lock (prv->lock) here, which causes system
> freeze. The reason is because when this function is called by
> schedule_dump() in schedule.c, the lock has already been grabbed. So I
> don't need the lock here, IMO. :-)

Oops. :-)

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel