Re: [Xen-devel] [PATCH 25/46] Use configure --mandir=DIR to set MANDIR

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-09-23 at 10:32 +0100, Ian Campbell wrote:
> On Mon, 2014-09-22 at 15:00 +0200, Olaf Hering wrote:
> > diff --git a/m4/paths.m4 b/m4/paths.m4
> > index 0255966..5e90eb4 100644
> > --- a/m4/paths.m4
> > +++ b/m4/paths.m4
> > @@ -68,6 +68,10 @@ AC_SUBST(XEN_LIB_STORED)
> >  SHAREDIR=$prefix/share
> >  AC_SUBST(SHAREDIR)
> >  
> > +dnl double eval because default mandir includes datarootdir, which 
> > includes prefix
> > +MANDIR=`eval eval echo $mandir`
> > +AC_SUBST(MANDIR)
> 
> Would it be better to add datarootdir to the "expand these early" at the
> top, something like
>       datarootdir=`eval echo $datarootdir`
> ?

Similarly for the following few patches...

Ideally there would be an autoconf mechanism to allow us to expand all
of these vars before we got to the point of using them.

Maybe we are just using it wrong and we should be doing in Paths.mk.in:
        prefix=@prefix@
        datarootdir=@datarootdir@
        mandir=@mandir@
        ...
        MANDIR=\$mandir

(or even just switching our code to $mandir). Perhaps looking at what
automake would put in Makefile.in for a generic project would be
informative?

That would be a bigger change though and I'd be OK with deferring for
now.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel