Re: [Xen-devel] [PATCH for-4.5 v7 21/21] tools/tests: Enable xen-access on ARM

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-09-22 at 19:11 +0200, Tamas K Lengyel wrote:
> 
> 
> On Mon, Sep 22, 2014 at 2:29 PM, Ian Campbell
> <Ian.Campbell@xxxxxxxxxx> wrote:
>         On Wed, 2014-09-17 at 22:51 +0200, Tamas K Lengyel wrote:
>         > diff --git a/config/arm32.mk b/config/arm32.mk
>         > index aa79d22..4a7c259 100644
>         > --- a/config/arm32.mk
>         > +++ b/config/arm32.mk
>         > @@ -13,6 +13,7 @@ HAS_PL011 := y
>         >  HAS_EXYNOS4210 := y
>         >  HAS_OMAP := y
>         >  HAS_NS16550 := y
>         > +HAS_MEM_ACCESS := y
>         
>         I think this (and the others) duplicate the one added to
>         arch/*/Rules.mk
>         in a previous patch. I think you can get away with only this
>         one (since
>         it is ultimately included I think).
>         
>         For x86 I'd suggest doing the MEM_PAGING one here too for
>         consistency.
>         
>         Ian.
> 
> 
> Ack, what about MEM_SHARING? I think that should be defined the same
> way.

I forgot that one, I agree they should be all in the same place.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel