Re: [Xen-devel] [PATCH for-4.5 v6 09/16] tools: Add limited support of VMware's hyper-call rpc

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sat, 2014-09-20 at 14:07 -0400, Don Slutz wrote:
>   This guestinfo support is provided via libxc.  libxl support has
> not be written.
> 
> Note: VMware RPC support is only available on HVM domU.
> 
> This interface is an extension of __HYPERVISOR_HVM_op.  It was
> picked because xc_get_hvm_param() also uses it and VMware guest
> info is a lot like a hvm param.
> 
> The HVMOP_get_vmport_guest_info is used by two libxc functions,
> xc_get_vmport_guest_info and xc_fetch_all_vmport_guest_info.
> xc_fetch_all_vmport_guest_info is designed to be used to fetch all
> currently set guestinfo values.
> 
> Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>

These look to be correct implementations of accessors for the hypercalls
as defined, although apart from my query about whether this belongs in
Xen at all I do have concerns about an hvm param argument struct of >4K.
AIUI more normal would be to have two GUEST_HANDLE* fields and to copy
in/out explicitly.

Ultimately that's up to the hypervisor maintainers though.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel