Re: [Xen-devel] [PATCH V5 01/15] move x86 EFI boot/runtime code to common/efi

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-09-19 at 09:49 +0100, Jan Beulich wrote:
> >>> On 19.09.14 at 00:49, <roy.franz@xxxxxxxxxx> wrote:
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -100,6 +100,7 @@ $(TARGET): delete-unfresh-files
> >     $(MAKE) -C tools
> >     $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h
> >     [ -e include/asm ] || ln -sf asm-$(TARGET_ARCH) include/asm
> > +   [ -e arch/$(TARGET_ARCH)/efi ] && ln -sf $(BASEDIR)/common/efi/* 
> > arch/$(TARGET_ARCH)/efi/
> 
> I guess this would better be
> 
>       ln -sf ../../../common/efi/* arch/$(TARGET_ARCH)/efi/
> 
> - there's no reason to prevent the tree from being moved.
> 
> Also I hope the recurring link creation upon incremental rebuilds
> isn't going to cause any kind of problems.

FWIW my finger macros usually use ln -nfs to avoid issues of this type
of thing, although maybe that's only for directory targets, since the -n
stops it creating ever deeper links within the original target.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel