Re: [Xen-devel] [PATCH for-4.5 v7 04/21] xen: Relocate set_access_required domctl into common

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Thu, Sep 18, 2014 at 12:36 PM, Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx> wrote:

On Thu, Sep 18, 2014 at 11:18 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 17.09.14 at 22:51, <tklengyel@xxxxxxxxxxxxx> wrote:
> Signed-off-by: Tamas K Lengyel <tklengyel@xxxxxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
with one minor remark:

> --- a/xen/include/asm-arm/p2m.h
> +++ b/xen/include/asm-arm/p2m.h
> @@ -198,6 +198,9 @@ int arch_grant_map_page_identity(struct domain *d, unsigned long frame,
>                                   bool_t writeable);
>  int arch_grant_unmap_page_identity(struct domain *d, unsigned long frame);
>
> +/* get host p2m table */
> +#define p2m_get_hostp2m(d) (&((d)->arch.p2m))

There's a superfluous pair of parentheses here.

Jan

Ack, I find it more readable to have &() when dereferencing a pointer within the parenthesis.

Tamas

Ah, you mean around (d), I see it now.

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel