Re: [Xen-devel] [PATCH for-4.5 v7 09/21] x86/p2m: Fix conversion macro of p2m_access to XENMEM_access

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Thu, Sep 18, 2014 at 11:35 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:

>>> On 17.09.14 at 22:51, <tklengyel@xxxxxxxxxxxxx> wrote:
> Signed-off-by: Tamas K Lengyel <tklengyel@xxxxxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

and I think this should really be committed as soon as possible, without
regard to the rest of this series.

Jan

Agree. It's benign right now as p2m_access is 1:1 mapped with XENMEM_access, but that's just by luck.

Tamas

 

> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -1402,7 +1402,7 @@ int p2m_get_mem_access(struct domain *d, unsigned long pfn,
>      mfn_t mfn;
>
>      static const xenmem_access_t memaccess[] = {
> -#define ACCESS(ac) [XENMEM_access_##ac] = XENMEM_access_##ac
> +#define ACCESS(ac) [p2m_access_##ac] = XENMEM_access_##ac
>              ACCESS(n),
>              ACCESS(r),
>              ACCESS(w),

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel