Re: [Xen-devel] [PATCH for-4.5 v7 07/21] xen: Relocate p2m_mem_access_check into common and refactor it.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.09.14 at 22:51, <tklengyel@xxxxxxxxxxxxx> wrote:
> --- a/xen/include/xen/mm.h
> +++ b/xen/include/xen/mm.h
> @@ -131,6 +131,10 @@ struct npfec {
>  #define MAX_ORDER 20 /* 2^20 contiguous pages */
>  #endif
>  
> +#define PAGE_ORDER_4K       0
> +#define PAGE_ORDER_2M       9
> +#define PAGE_ORDER_1G       18
> +

Are these really defines useful in a architecture independent manner?
I think if specific page sizes warrant such definitions, they ought to
e.g. live in the per-arch config.h. And their use in common code is
of course very bogus (implying a certain granularity of the underlying
(v)MMU).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel