Re: [Xen-devel] [PATCH] passthrough: streamline _hvm_dirq_assist()

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.09.14 at 22:32, <konrad.wilk@xxxxxxxxxx> wrote:
> On Thu, Sep 11, 2014 at 02:14:43PM +0100, Jan Beulich wrote:
>> The loop inside this function was calling two functions with loop-
>> invariable arguments which clearly don't need calling more than once:
>> send_guest_pirq() and __msi_pirq_eoi(). After moving these out of the
>> loop it further became apparent that folding the hvm_pci_msi_assert()
>> helper into the main function can further help readability.
>> 
>> In the course of this I noticed that __hvm_dpci_eoi() called
>> hvm_pci_intx_deassert() unconditionally, whereas hvm_pci_intx_assert()
>> (correctly) got called only when !hvm_domain_use_pirq(), so the former
>> is being made conditional now too.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> 
> Thought I would also like to test it first, so if you are OK with
> waiting until I send out an 'Tested-by' I would appreciate it.

Too late - it passed the push gate yesterday already.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel