Re: [Xen-devel] [PATCH] clang: sizeof(type) must not have __attribute__(aligned)

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi,

On 17/09/14 03:50, Jan Beulich wrote:
> > > > On 16.09.14 at 20:32, <ian.campbell@xxxxxxxxxx> wrote:
> > On Tue, 2014-09-16 at 11:26 -0700, Julien Grall wrote:
> > > Hi Ian,
> > >
> > > On 16/09/14 09:21, Ian Campbell wrote:
> > > > On Sat, 2014-09-13 at 18:42 +0000, Marcin Cieslak wrote:
> > > >
> > > > The commit message could go into a bit more detail as to why this is not
> > > > allowed. To me it sounds like clang is being overly picky, surely it can
> > > > just ignore the alignment in that context?
> > > Clang will throw a warning when an attribute is unused (see
> > > -Wignored-attributes). In case of libxc, we compiled with -Werror which
> > > will turn this warning into an error.
> > Sounds to me like -Wignored-attributes is a bit pointless, perhaps we
> > shouldn't use it?
> +1
Ian, shall I resend the patch which disabled this attribute?

https://patches.linaro.org/27062/

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel