Re: [Xen-devel] [PATCH v11 2/2] x86/viridian: Add partition time reference counter MSR support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.09.14 at 19:18, <paul.durrant@xxxxxxxxxx> wrote:
> +    case VIRIDIAN_MSR_TIME_REF_COUNT:
> +    {
> +        uint64_t tsc;
> +        struct time_scale tsc_to_ns;
> +
> +        if ( !(viridian_feature_mask(d) & HVMPV_time_ref_count) )
> +            return 0;
> +
> +        perfc_incr(mshv_rdmsr_time_ref_count);
> +        tsc = hvm_get_guest_tsc(pt_global_vcpu_target(d));
> +
> +        /* convert tsc to count of 100ns periods */
> +        set_time_scale(&tsc_to_ns, (uint64_t)d->arch.tsc_khz * 1000ul);

As I keep pushing a private note for when this can eventually be
applied from one revision to the next - should you have to do
another round, could I ask you to drop the pointless cast here?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel