Re: [Xen-devel] [PATCH v4 02/16] tools: Add vmware_hw support

[Don Slutz <dslutz@xxxxxxxxxxx>]

On 09/11/14 17:09, Andrew Cooper wrote:
> On 11/09/2014 19:36, Don Slutz wrote:
> > This is used to set HVM_PARAM_VMWARE_HW. It is set to the VMware
> > virtual hardware version.
> >
> > Currently 0, 3-4, 6-11 are good values.  However the code only
> > checks for == 0 or != 0.
> >
> > If non-zero then
> >    default VGA to VMware's VGA.
> >
> > Also now allows vga=vmware
> >
> > Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>
> > ---
> >   docs/man/xl.cfg.pod.5               | 21 +++++++++++++++++++--
> >   docs/misc/hypervisor-cpuid.markdown | 29 +++++++++++++++++++++++++++++
> >   tools/libxc/xc_domain_restore.c     | 14 ++++++++++++++
> >   tools/libxc/xc_domain_save.c        | 11 +++++++++++
> >   tools/libxc/xg_save_restore.h       |  2 ++
> >   tools/libxl/libxl.h                 | 10 ++++++++++
> >   tools/libxl/libxl_create.c          |  4 +++-
> >   tools/libxl/libxl_dm.c              | 10 +++++++++-
> >   tools/libxl/libxl_dom.c             |  2 ++
> >   tools/libxl/libxl_types.idl         |  2 ++
> >   tools/libxl/xl_cmdimpl.c            | 11 ++++++++++-
> >   11 files changed, 111 insertions(+), 5 deletions(-)
> >   create mode 100644 docs/misc/hypervisor-cpuid.markdown
> >
> > diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
> > index 517ae2f..367b401 100644
> > --- a/docs/man/xl.cfg.pod.5
> > +++ b/docs/man/xl.cfg.pod.5
> > @@ -1147,6 +1147,23 @@ some other Operating Systems and in some circumstance 
> > can prevent
> >   Xen's own paravirtualisation interfaces for HVM guests from being
> >   used.
> >   
> > +=item B<vmware_hw=NUMBER>
> > +
> > +Turns on or off the exposure of VMware cpuid.  The number is the
> > +VMware's hardware version number, where 0 is off.  If not zero it
> > +changes the default VGA to VMware's VGA.
> > +
> > +The hardware version number (vmware_hw) come from VMware config files.
> > +
> > +=over 4
> > +
> > +In a .vmx it is virtualHW.version
> > +
> > +In a .ovf it is part of the value of vssd:VirtualSystemType.
> > +For vssd:VirtualSystemType == vmx-07, vmware_hw = 7.
> > +
> > +=back
> > +
> >   =back
> >   
> >   =head3 Emulated VGA Graphics Device
> > @@ -1185,8 +1202,8 @@ This option is deprecated, use vga="stdvga" instead.
> >   
> >   =item B<vga="STRING">
> >   
> > -Selects the emulated video card (none|stdvga|cirrus).
> > -The default is cirrus.
> > +Selects the emulated video card (none|stdvga|cirrus|vmware).
> > +The default is cirrus (or vmware if B<vmware_hw> is not zero).
> >   
> >   =item B<vnc=BOOLEAN>
> >   
> > diff --git a/docs/misc/hypervisor-cpuid.markdown b/docs/misc/hypervisor-cpuid.markdown
> > new file mode 100644
> > index 0000000..4199d57
> > --- /dev/null
> > +++ b/docs/misc/hypervisor-cpuid.markdown
> > @@ -0,0 +1,29 @@
> > +Hypervisor Cpuid
> > +================
> > +
> > +The support of hypervisor cpuid leaves has not been agreed to.
> > +Other then the range 0x40000000 to 0x400000ff can be used by
> > +hypervisors.
> > +
> > +MicroSoft Hyper-V (AKA viridian) currently must be at 0x40000000.
> > +
> > +VMware currently must be at 0x40000000.
> > +
> > +KVM currently must be at 0x40000000 (from Seabios).
> > +
> > +Seabios will find Xen at 0x40000000, 0x40000100, 0x40000200 ..
> > +0x40010000.
> Anything looking for Xen according to the Xen cpuid instructions in the
> public header files will find Xen in this manner;  hvmloader and
> HVMLinux to name but a few.  I don't think Seabios wants calling out
> specifically.
>
> Perhaps "Xen can be found at the first otherwise unused 0x100 aligned
> offset between 0x40000000 and 0x40010000"?
Looks fine to me.  Will change.
    -Don Slutz

> ~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel