Re: [Xen-devel] [PATCH v3 1/4] xen: add real time scheduler rtds

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Tue, 2014-09-16 at 09:52 +0100, Jan Beulich wrote:
> >>> On 16.09.14 at 10:42, <dario.faggioli@xxxxxxxxxx> wrote:
> > On Sun, 2014-09-14 at 17:37 -0400, Meng Xu wrote:

> >> +    list_for_each_safe(iter, tmp, runq)
> >> +    {
> >> +        svc = __q_elem(iter);
> >> +
> >> +        if ( now >= svc->cur_deadline )
> >> +        {
> >> +            rt_update_deadline(now, svc);
> >> +            /* reinsert the vcpu if its deadline is updated */
> >> +            __q_remove(svc);
> >> +            __runq_insert(ops, svc);
> >> +        }
> >> +        else
> >> +            break;
> >>
> > Just from an aesthetic perspective, I think I'd have inverted the
> > condition and, hence, the two brances (i.e., "if ( < ) break; else {}").
> 
> In which case the "else" and with it one level of indentation
> should go away.
> 
Indeed. That was the idea behind my comment in the first place and in my
mind, then, while putting that into written words, I messed up! :-/

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel