Re: [Xen-devel] [PATCH v3 3/4] libxl: add rtds scheduler

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On Sun, 2014-09-14 at 17:37 -0400, Meng Xu wrote:
> Add libxl functions to set/get domain's parameters for rtds scheduler
> Note: VCPU's information (period, budget) is in microsecond (us).
> 
> Signed-off-by: Meng Xu <mengxu@xxxxxxxxxxxxx>
> Signed-off-by: Sisu Xi <xisisu@xxxxxxxxx>
>
With the proper LIBXL_HAVE_XXX added:

Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

As Ian said, look at libxl.h. You're adding a valid enum value ("rtds")
in libxl_scheduler, and a "budget" field in libxl_domain_sched_params.

I'm not sure whether I'd go for something like

#define LIBXL_HAVE_SCHED_RTDS 1

or

#define LIBXL_HAVE_SCHEDPARAMS_BUDGET 1

If it were me, I probably would have added both, but perhaps both is too
much...

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel