Re: [Xen-devel] [PATCH for-4.5 v2 1/2] xen: refactor physical address space compression support into common code

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.09.14 at 17:15, <ian.campbell@xxxxxxxxxx> wrote:
> The "pdx compression" functionality will be useful on ARM as well.
> 
> Move the code to common code+header and introduce HAS_PDX to control when it 
> is
> built. L2_PAGETABLE_SHIFT is x86 specific, so introduce PDX_GROUP_SHIFT to
> abstract it out.
> 
> ARM has no need for superpage compression (yet?) and lacks SUPERPAGE_SHIFT 
> so
> those functions (spage_to_mfn et al) are not moved.
> 
> No affect on x86 and no change for ARM (yet).
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> v2:
>  - Correct closing guard comment in pdx.h

Hmm, looking at it ...

> --- /dev/null
> +++ b/xen/include/xen/pdx.h
> @@ -0,0 +1,47 @@
> +#ifndef __XEN_PDX_H__
> +#define __XEN_PDX_H__
> +
> +#ifdef HAS_PDX

... is it HAS_PDX ...

> +#endif /* HAVE_PDX */

... or HAVE_PDX?

Jan

> +#endif /* __XEN_PDX_H__ */
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel