Re: [Xen-devel] [PATCH V4 04/15] Add architecture functions for pre/post ExitBootServices

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-09-12 at 08:08 +0100, Jan Beulich wrote:
> >>> On 11.09.14 at 19:44, <roy.franz@xxxxxxxxxx> wrote:
> > On Thu, Sep 11, 2014 at 7:13 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> >>>>> On 10.09.14 at 02:51, <roy.franz@xxxxxxxxxx> wrote:
> >>>      status = efi_bs->ExitBootServices(ImageHandle, mmap_key);
> >>>      if ( EFI_ERROR(status) )
> >>>          PrintErrMesg(L"Cannot exit boot services", status);
> >>>
> >>> -    /* Adjust pointers into EFI. */
> >>> -    efi_ct = (void *)efi_ct + DIRECTMAP_VIRT_START;
> >>> -#ifdef USE_SET_VIRTUAL_ADDRESS_MAP
> >>> -    efi_rs = (void *)efi_rs + DIRECTMAP_VIRT_START;
> >>> -#endif
> >>> -    efi_memmap = (void *)efi_memmap + DIRECTMAP_VIRT_START;
> >>> -    efi_fw_vendor = (void *)efi_fw_vendor + DIRECTMAP_VIRT_START;
> >>> -
> >>> -    efi_arch_relocate_image(__XEN_VIRT_START - xen_phys_start);
> >>
> >> Up to here I don't see anything arch-specific again.
> > This is due to runtime services not being implemented.  The "efi_rs"
> > variable is defined in the runtime services
> > file runtime.c, which is not yet ported to ARM.
> > 
> > Short of including ARM runtime service support in the patchset, how
> > would you like this handled?
> 
> As said before, everything that's generic but not used/usable on
> ARM right now should stay here, but get made conditional in one
> or another way.

So in this case a HAVE_EFI_RUNTIMESERVICES ifdef would work?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel