Re: [Xen-devel] [PATCH v5 02/17] xen: Relocate p2m_mem_access_resume to mem_access common

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Thu, Sep 11, 2014 at 10:16 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:

Hi Tamas,

On 10/09/14 06:28, Tamas K Lengyel wrote:

  /* Registered with Xen-bound event channel for incoming notifications. */
diff --git a/xen/include/asm-x86/p2m.h b/xen/include/asm-x86/p2m.h
index 39f235d..2a8970b 100644
--- a/xen/include/asm-x86/p2m.h
+++ b/xen/include/asm-x86/p2m.h
@@ -601,8 +601,6 @@ void p2m_mem_paging_resume(struct domain *d);
  bool_t p2m_mem_access_check(paddr_t gpa, unsigned long gla,
                              struct npfec npfec,
                              mem_event_request_t **req_ptr);
-/* Resumes the running of the VCPU, restarting the last instruction */

> -void p2m_mem_access_resume(struct domain *d);
>

I think this comment is useful to keep. I will move it above mem_access_resume prototype in mem_access.h

Ack.

 

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel