Re: [Xen-devel] [PATCH v2 1/2] x86/HVM: fix miscellaneous aspects of x2APIC emulation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.09.14 at 17:39, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 10/09/14 14:43, Jan Beulich wrote:
>> --- a/xen/arch/x86/hvm/vlapic.c
>> +++ b/xen/arch/x86/hvm/vlapic.c
>> @@ -602,6 +602,7 @@ int hvm_x2apic_msr_read(struct vcpu *v, 
>>          break;
>>  
>>      case APIC_ICR2:
>> +    case APIC_SELF_IPI:
> 
> APIC_EOI is also write-only, generates #GP(0) on on rdmsr, and isn't
> caught by vlapic_read_aligned().

Of course - not sure how I managed to overlook that.

> Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks, but together with the above I actually realized I should do
some further changes in v3.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel