Re: [Xen-devel] [PATCH V4 15/15] Add ARM EFI boot support

[Roy Franz <roy.franz@xxxxxxxxxx>]

On Thu, Sep 11, 2014 at 7:53 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 10.09.14 at 02:52, <roy.franz@xxxxxxxxxx> wrote:
>> --- a/xen/common/Makefile
>> +++ b/xen/common/Makefile
>> @@ -67,4 +67,5 @@ subdir-$(x86_64) += hvm
>>  subdir-$(coverage) += gcov
>>
>>  subdir-y += libelf
>> +subdir-$(CONFIG_EFI) += efi
>>  subdir-$(HAS_DEVICE_TREE) += libfdt
>
> Hmm, this will suggest to the reader that either x86 doesn't support
> EFI, or it gets built this way too. Both of which is wrong. I think the
> symlink mechanism should be used the same way as for x86.
>
> Jan
>

The common build infrastructure works quite nicely for ARM.  I can
create an arch/arm/efi, and
make symlink, etc. like x86, but this seems silly to me.  The x86 EFI
build is special in the way
it autodetects toolchain capability, but I don't think that these
complications (or side effects of these
x86 specific complications) should be copied for symmetry with x86 as
the only reason.

If the Makefile is misleading, I'd rather address that with a comment
in the Makefile

Roy

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel