Re: [Xen-devel] [PATCH V4 01/15] move x86 EFI boot code to common/efi

[Roy Franz <roy.franz@xxxxxxxxxx>]

On Thu, Sep 11, 2014 at 6:50 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>> On 10.09.14 at 02:51, <roy.franz@xxxxxxxxxx> wrote:
>> --- /dev/null
>> +++ b/xen/arch/x86/efi/boot.c
>> @@ -0,0 +1 @@
>> +../../../common/efi/boot.c
>> \ No newline at end of file
>
> That's certainly not how I envisioned it - I rather expected the
> symlink to be created at build time. That's in any event the more
> portable solution (for example I tend to keep source trees on
> Windows machines for reference, and I don't think symlinks get
> properly expressed there when e.g. extracted from a tarball -
> may depend on the tool used of course).
>
> Just create it together with the include/asm one.

OK, I will create the symlink at build time
>
> And then, as said before, I don't think relocating just boot.c is
> going to be sufficient, in which case it would seem more consistent
> to move all relevant files in one go.

I can move the other file - I think runtime.c would be the only other to move,
but it is not used by this patchset.  This patchset is limited to EFI
boot support.
Runtime services support, ACPI, etc all depend on this functionality,
but are not
being addressed in this patchset.
I can move runtime.c to common/efi, but the only place it will be used
is x86/efi.

This touches on an issue in a number of the following patches - some
of the things moved to
the arch specific file are EFI related things that are not truly
architecture specific, but are not yet
implemented for ARM and are beyond the scope of this patchset.  My
intent is for these to be adjusted
when those features (such as runtime services) are implemented for
ARM.  There are other non-EFI specific
things like VGA, which aren't currently in the ARM build, but are
setup in boot.c, but aren't truly architecture specific.

>
>> diff --git a/xen/arch/x86/efi/efi.h b/xen/include/asm-x86/efi.h
>> similarity index 100%
>> rename from xen/arch/x86/efi/efi.h
>> rename to xen/include/asm-x86/efi.h
>
> This adjustment (and the related ones) seems unnecessary. The
> header is strictly local to xen/arch/x86/efi/ (and should remain
> unexposed after the move, but might of course be moved along
> with the other files).

Yup - I moved this when I moved boot.c, and forgot to undo this when
boot.c is linked back to its original location.

>
> Jan
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel