Re: [Xen-devel] [PATCH V7 for-4.5 4/4] xen: Handle resumed instruction based on previous mem_event reply

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.09.14 at 17:21, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> Sorry, I don't quite follow that. Currently,
> v->arch.mem_event.emulate_flags serves both as a way to know if
> emulation is required (0 if no emulation is required, and != 0 if
> emulation is required), and as a way to know which kind of emulation is
> required ("regular" emulation, or emulation with writes disabled).
> 
> Making it into a bool_t would make it possible to know that emulation is
> required, but not which kind of emulation:
> 
> +    if ( v->arch.mem_event.emulate_flags )
> +    {
> +        hvm_mem_event_emulate_one((v->arch.mem_event.emulate_flags &
> +                                   MEM_EVENT_FLAG_EMULATE_NOWRITE) != 0,

Ah, right, I somehow managed to overlook this dual purpose.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel