Re: [Xen-devel] [PATCH V4 12/15] Add efi_arch_use_config_file() function to control use of config file

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 10.09.14 at 02:52, <roy.franz@xxxxxxxxxx> wrote:
> -    cols = rows = depth = 0;
> -    if ( !base_video )
> -    {
> -        name.cs = get_value(&cfg, section.s, "video");
> -        if ( !name.cs )
> -            name.cs = get_value(&cfg, "global", "video");
> -        if ( name.cs && !strncmp(name.cs, "gfx-", 4) )
> +        cols = rows = depth = 0;
> +        if ( !base_video )
>          {
> -            cols = simple_strtoul(name.cs + 4, &name.cs, 10);
> -            if ( *name.cs == 'x' )
> -                rows = simple_strtoul(name.cs + 1, &name.cs, 10);
> -            if ( *name.cs == 'x' )
> -                depth = simple_strtoul(name.cs + 1, &name.cs, 10);
> -            if ( *name.cs )
> -                cols = rows = depth = 0;
> +            name.cs = get_value(&cfg, section.s, "video");
> +            if ( !name.cs )
> +                name.cs = get_value(&cfg, "global", "video");
> +            if ( name.cs && !strncmp(name.cs, "gfx-", 4) )
> +            {
> +                cols = simple_strtoul(name.cs + 4, &name.cs, 10);
> +                if ( *name.cs == 'x' )
> +                    rows = simple_strtoul(name.cs + 1, &name.cs, 10);
> +                if ( *name.cs == 'x' )
> +                    depth = simple_strtoul(name.cs + 1, &name.cs, 10);
> +                if ( *name.cs )
> +                    cols = rows = depth = 0;
> +            }

So how is this video mode selection being represented then without
config file? Don't you need to at least add a command line option for
that?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel