Re: [Xen-devel] [PATCH 23/29] tools/libxl: Extend datacopier to support reading into a buffer

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-09-11 at 13:26 +0100, Ross Lagerwall wrote:
> On 09/11/2014 01:03 PM, Ian Campbell wrote:
> > On Wed, 2014-09-10 at 18:11 +0100, Andrew Cooper wrote:
> >> From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> >>
> >> Implement a read-only mode for libxl__datacopier.
> >
> > Read-only in the sense that it only reads, or in the sense that one may
> > only read from it?
> 
> It only reads rather than reading and writing.
> 
> >
> > What is the purpose of this mode?
> >
> > Where does the data go?
> >
> 
> This mode allows data from an fd to be read into memory using libxl's 
> async framework. The data goes into the user-allocated 
> libxl__datacopier_state.readbuf.

OK. I think you can probably guess what I'm going to say.

In addition to the commit log I'm sure that the doc comments in the
headers must needs some updating for all this new functionality (here
and the surrounding patches).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel