Re: [Xen-devel] [PATCH v3 08/15] libxl: introduce helper to initialise Dom0

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-09-04 at 23:43 +0100, Wei Liu wrote:
> This small helper is responsible for generating Dom0 JSON config
> stub and writing Dom0 xenstore entries. This helpers subsumes two calls
> to xenstore-write in xencommons script.
> 
> Dom0 UUID is intentionally left untouched, so it is always all
> zeros.  This makes sure that we don't leak Dom0 stubs across rebooting.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>

With the *BSD followup folded in:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

(I'll do the folding on commit unless there is some other reason to
resend).

One comment for a potential future cleanup:

> +    /* Sanity check: this program can only be run once. */

I suppose parallel invocations of the initscript are unlikely. But if we
cared about such things then some locking would be needed, perhaps in
the form of a xenstore transaction or a droppings in /var/lib/subsys.

But how harmful is running this again? Since the UUID is statically all
zeroes isn't it idemopotent?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel