Re: [Xen-devel] [PATCH] xen: remove DEFINE_XENBUS_DRIVER() macro

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.09.14 at 18:46, <david.vrabel@xxxxxxxxxx> wrote:
> The DEFINE_XENBUS_DRIVER() macro looks a bit weird and causes sparse
> errors.
> 
> Replace the uses with standard structure definitions instead.  This is
> similar to pci and usb device registration.
> 
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>

I really regret you doing this, re-adding redundancy the elimination
of which the macro got added for (the diffstat would look even less
favorable if your patch didn't eliminate a couple of bogus comments
and blank lines). I'm certainly not in the position to nack this patch,
but if I was I would.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel