Re: [Xen-devel] [PATCH v4 16/16] tools/tests: Enable xen-access on ARM

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Tamas,

On 05/09/14 01:58, Tamas K Lengyel wrote:
> On ARM the guest memory doesn't start from 0 and has multiple banks
> of memory, thus we adjust the setting/unsetting routines accordingly.
> We also define the ARM specific test_and_set_bit function.
>
> Signed-off-by: Tamas K Lengyel <tklengyel@xxxxxxxxxxxxx>
> ---
> v4: - Take into account multiple guest ram banks on ARM.
>      - Move HAS_MEM_ACCESS definition into config/*.mk and only compile
>        xen-access when it is defined.
>      - Pass CONFIG_X86/CONFIG_ARM flags during compilation in xen-access
>        Makefile.
> ---
>   config/arm32.mk                     |  1 +
>   config/arm64.mk                     |  1 +
>   config/x86_32.mk                    |  2 +
>   config/x86_64.mk                    |  2 +
>   tools/tests/xen-access/Makefile     |  9 +++-
>   tools/tests/xen-access/xen-access.c | 94 +++++++++++++++++++++++++++++++++----
>   xen/arch/arm/Rules.mk               |  1 -
>   xen/arch/x86/Rules.mk               |  1 -
>   8 files changed, 97 insertions(+), 14 deletions(-)
>
> diff --git a/config/arm32.mk b/config/arm32.mk
> index aa79d22..4a7c259 100644
> --- a/config/arm32.mk
> +++ b/config/arm32.mk
> @@ -13,6 +13,7 @@ HAS_PL011 := y
>   HAS_EXYNOS4210 := y
>   HAS_OMAP := y
>   HAS_NS16550 := y
> +HAS_MEM_ACCESS := y
Why can't you move HAS_MEM_ACCESS directly here in patch #1?

It would make this patch simpler.

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel