Re: [Xen-devel] [PATCH 2/2] xen/gntalloc: safely delete grefs in add_grefs() undo path

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 02/09/14 22:54, Boris Ostrovsky wrote:
> On 09/02/2014 10:21 AM, David Vrabel wrote:
>> If a gref could not be added (perhaps because the limit has been
>> reached or there are no more grant references available).  The undo
>> path may crash because __del_gref() frees the gref while it is being
>> used for a list iteration.
> 
> Need to fix commit message above.
> 
>>
>> A comment suggests that using list_for_each_entry() is safe since the
>> gref isn't removed from the list being iterated over, but it is freed
>> and thus list_for_each_entry_safe() must be used.
> 
> I don't read the comment in the code as if it implied anything about
> safety.
> 
> Other than that, for both patches
> 
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

Applied to stable/for-linus-3.17-b.

Thanks

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel