Re: [Xen-devel] [PATCH v5] xen: arm: introduce uImage probe function for Dom0

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-08-29 at 16:51 -0400, Julien Grall wrote:
> Hi Oleksandr,
> 
> On 28/08/14 06:54, Oleksandr Dmytryshyn wrote:
> >   #ifdef CONFIG_ARM_64
> >   /*
> >    * Check if the image is a 64-bit Image.
> > @@ -398,6 +467,8 @@ int kernel_probe(struct kernel_info *info)
> >       rc = kernel_zimage64_probe(info, start, size);
> >       if (rc < 0)
> >   #endif
> > +        rc = kernel_uimage_probe(info, start, size);
> > +    if(rc < 0 )
> 
> NIT: the coding style is:
> 
> if ( rc < 0 )
> 
> It looks like the other if in this function don't respect the coding 
> style. I wouldn't resend a new version of this patch this small NIT. 
> Maybe Ian can fix it when it will be applied?

I fixed it to match the surrounding (but also wrong) coding style, so at
least it is now consistent.

> Anyway:
> 
> Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>

thanks, akced + applied

> +        printk(XENLOG_ERR "Not supported uImage arch type %d\n", 
> uimage->arch);

I made this say "Unsupported ..." which reads more naturally to me. I
hope that's ok.

I also had to switch this and the switch() to use uimage.arch not
uimage->arch. Please at least compile test arm64 hypervisor changes when
touching common code (I don't insist for userspace since it is hard to
get hold of a suitable environment). The hypervisor cross compiles quite
easily using e.g. the linaro toolchains.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel