Re: [Xen-devel] [PATCH ARM v7 11/13] mini-os: arm: build system

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-08-08 at 16:47 +0100, Thomas Leonard wrote:
> Based on an initial patch by Karim Raslan.
> 
> This activates the ARM code added in the previous patches. On ARM,
> Mini-OS will boot and display some output on the console. Tested with:
> 
> make XEN_TARGET_ARCH=arm32 CROSS_COMPILE=arm-linux-gnueabihf- \
>       CONFIG_TEST=y CONFIG_START_NETWORK=n CONFIG_BLKFRONT=n \
>       CONFIG_NETFRONT=n CONFIG_FBFRONT=n CONFIG_KBDFRONT=n \
>       CONFIG_CONSFRONT=n CONFIG_XC=n -j4
> 
> The memmove implementation is from FreeBSD's
> contrib/ldns/compat/memmove.c (r246827).

This is ~= 3-clause BSD which over the existing license has:
> +    * Redistributions in binary form must reproduce the above copyright
> +      notice, this list of conditions and the following disclaimer in the
> +      documentation and/or other materials provided with the distribution.

I suppose this is somewhat tolerable but it might be nicer to avoid if
we can. Does anyone know of (or fancy knocking up) a clean room
memmove() under the 2-clause license used by the rest of minios?

> The change to fdt_ro.c is to avoid a compiler warning.

I was about to ask for it to be quoted, but I see that you don't
actually touch fdt_ro.c, so maybe this comment is just stale?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel