Re: [Xen-devel] [XEN/ARM PATCH v6 1/1] Add OdroidXU board (Exynos 5410)

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-09-04 at 15:57 -0700, Suriyan Ramasami wrote:
>     XEN/ARM: Add support for the Odroid-XU board.
> 
>     The Odroid-XU from hardkernel is an Exynos 5410 based board.
>     This patch adds support to the above said board.

Please could you describe a bit more fully the refactoring you've done
and the new platform you've introduced. e.g. that we now have a general
exynos5 (which currently includes only the 4210) and that the previous
5250 is a separate platform because of A, B, and C which differ from the
generic.

Assuming there are no other changes to the patch please feel free to
just reply here with the updated commit text and I'll fold it in as I
commit.

> @@ -77,20 +125,127 @@ static int __init exynos5_smp_init(void)
>  
>      printk("Set SYSRAM to %"PRIpaddr" (%p)\n",
>             __pa(init_secondary), init_secondary);
> -    writel(__pa(init_secondary), sysram);
> +    writel(__pa(init_secondary), sysram + 0x1c);

I think this 01c offset is new, where does it come from? Was the old
code wrong (again, if this just needs a few words in the commit log I
can fold them in as I commit).

> +    static const struct dt_device_match exynos_dt_pmu_matches[] __initconst =
> +    {
> +        DT_MATCH_COMPATIBLE("samsung,exynos5250-pmu"),
> +        DT_MATCH_COMPATIBLE("samsung,exynos5410-pmu"),
> +        DT_MATCH_COMPATIBLE("samsung,exynos5420-pmu"),

I suppose these are all similar enough for our purposes?

> +        { /*sentinel*/ },
> +    };
> +
> +    node = dt_find_matching_node(NULL, exynos_dt_pmu_matches);
> +    if ( !node )
> +    {
> +        dprintk(XENLOG_ERR, "samsung,exynos5XXX-pmu missing in DT\n");

We have some 4XXX in the list too. Make it exynosXXXX? (likewise the
next message which was below but I've trimmed it by mistake).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel