Re: [Xen-devel] [PATCH v9 1/9] xen: vnuma topology and subop hypercalls

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.09.14 at 13:25, <Ian.Campbell@xxxxxxxxxx> wrote:
> On Thu, 2014-08-28 at 23:04 -0400, Elena Ufimtseva wrote:
>> Define interface, structures and hypercalls for toolstack to
>> build vnuma topology and for guests that wish to retrieve it.
>> Two subop hypercalls introduced by patch:
>> XEN_DOMCTL_setvnumainfo to define vNUMA domain topology per domain
>> and XENMEM_get_vnumainfo to retrieve that topology by guest.
> 
> This (or a related patch) seems to have broken the build on ARM
> http://www.chiark.greenend.org.uk/~xensrcts/logs/30120/build-armhf/5.ts-xen- 
> build.log
> In file included from xenctrl.h:38:0,
>                  from xc_private.h:32,
>                  from xc_gnttab.c:20:
> /local/scratch/osstest/osstest/build.30120.build-armhf/xen/tools/libxc/../..
> /tools/include/xen/domctl.h:1101:33: error: field 'vnuma' has incomplete type
> 
> It looks like the definition of xen_domctl_vnuma is under a 
>         #if defined(__i386__) || defined(__x86_64__)
> but the uses are not.
> 
> It would probably be best for now to simply ifdef the uses in libxc too.

Actually the hypervisor build seems to be broken for ARM too (if you
look a little further down in the log) - we just should move the #endif
up, as there's nothing architecture specific here (even if ARM may
not immediately make use of this).

So Elena, going forward please at least build test your changes on
ARM too.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel