Re: [Xen-devel] [PATCH] xc_cpuid_x86.c: No need to mask NX twice

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.09.14 at 12:11, <alfred.z.song@xxxxxxxxx> wrote:
> Since amd_xc_cpuid_policy or intel_xc_cpuid_policy will do it later as
> well, we may drop an extra action.

But then I think it would be better to keep the generic one and
drop the vendor specific ones.

Jan

> Signed-off-by: Zhuo Song <songzhuo.sz@xxxxxxxxxxxxxxx>
> ---
>  tools/libxc/xc_cpuid_x86.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/libxc/xc_cpuid_x86.c b/tools/libxc/xc_cpuid_x86.c
> index 6b81641..61af3e6 100644
> --- a/tools/libxc/xc_cpuid_x86.c
> +++ b/tools/libxc/xc_cpuid_x86.c
> @@ -392,7 +392,6 @@ static void xc_cpuid_hvm_policy(
>  
>      case 0x80000001:
>          if ( !is_pae ) {
> -            clear_bit(X86_FEATURE_NX, regs[3]);
>              clear_bit(X86_FEATURE_PSE36, regs[3]);
>          }
>          break;
> -- 
> 1.8.5.2 (Apple Git-48)
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx 
> http://lists.xen.org/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel